From 8b3e3743f007e5040f894bf5493b1e6c3a0c5847 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Tue, 29 Aug 2023 14:39:26 -0600
Subject: [PATCH] convert googletakeout format to dynamic. (#1167)

---
 googletakeout.cc | 9 +++------
 googletakeout.h  | 6 ++++--
 vecs.cc          | 4 ++--
 3 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/googletakeout.cc b/googletakeout.cc
index d057ca502..a962aa49c 100644
--- a/googletakeout.cc
+++ b/googletakeout.cc
@@ -217,16 +217,13 @@ GoogleTakeoutFormat::title_case(QString& title)
 }
 
 void
-GoogleTakeoutFormat::rd_init(const QString& fname) {
+GoogleTakeoutFormat::read()
+{
   if (global_opts.debug_level >= 4) {
     Debug(4) << "rd_init(" << fname << ")";
   }
-  inputStream = GoogleTakeoutInputStream(fname);
-}
+  GoogleTakeoutInputStream inputStream(fname);
 
-void
-GoogleTakeoutFormat::read()
-{
   int items = 0;
   int points = 0;
   int place_visits = 0;
diff --git a/googletakeout.h b/googletakeout.h
index 6bf54b17a..ea549f6f5 100644
--- a/googletakeout.h
+++ b/googletakeout.h
@@ -65,6 +65,8 @@ private:
 class GoogleTakeoutFormat : public Format
 {
 public:
+  using Format::Format;
+
   /* Member functions */
   QVector<arglist_t>* get_args() override
   {
@@ -81,7 +83,8 @@ public:
     return { ff_cap_read, ff_cap_read, ff_cap_none };
   }
 
-  void rd_init(const QString& fname) override;
+  void rd_init(const QString& fname) override
+  {}
   void read() override;
  
 private:
@@ -119,7 +122,6 @@ private:
 
   /* Data Members */
 
-  GoogleTakeoutInputStream inputStream;
   QVector<arglist_t> googletakeout_args;
 };
 
diff --git a/vecs.cc b/vecs.cc
index 150f79a30..10c5fca2f 100644
--- a/vecs.cc
+++ b/vecs.cc
@@ -163,7 +163,6 @@ struct Vecs::Impl {
   GeoJsonFormat geojson_fmt;
   GlobalsatSportFormat globalsat_sport_fmt;
   QstarzBL1000Format qstarz_bl_1000_fmt;
-  GoogleTakeoutFormat google_timeline_fmt;
 #endif // MAXIMAL_ENABLED
 
   const QVector<vecs_t> vec_list {
@@ -495,11 +494,12 @@ struct Vecs::Impl {
       nullptr,
     },
     {
-      &google_timeline_fmt,
+      nullptr,
       "googletakeout",
       "Google Takeout Location History",
       "json",
       nullptr,
+      &fmtfactory<GoogleTakeoutFormat>
     }
 #endif // MAXIMAL_ENABLED
   };
-- 
2.30.2